qri-io / rfcs

Request For Comments (RFCs) documenting changes to Qri
MIT License
12 stars 6 forks source link

RFC: CLI commands #14

Closed ramfox closed 6 years ago

ramfox commented 6 years ago

List of commands, flags, and expected behavior

ramfox commented 6 years ago

@b5 plz halp

I'm having trouble with qri peers disconnect. Is this meant to be a way to close your connection to a peer, so that the peer is essentially blocked? Or just close your explicit connection to it right now. Will this prevent automatically connecting to this peer in the future? Is this supposed to be temporary? If you close the connection, can the peer just re-open it using qri peers connect?

It seems right now that you don't have to be connected to a peer in order for that peer to be connected to you. Which you mentioned, which seems like an error in libp2p.

But regardless, trying to understand the spirit of what qri peers disconnect is supposed to be.

I'm worried it can read as a security function (block this peer, don't let it see my info/datasets), but I'm pretty sure that's not what it's supposed to do.

b5 commented 6 years ago

qri peers disconnect is supposed to just close your explicit connection to a peer at that moment. In the future I think we should augment something akin to qri peers with qri peers block and qri peers unblock, which implement the blocking semantics you're describing 🛩

b5 commented 6 years ago

And yes, it's a bug that connections are currently "one way", I'm hoping this will self-rectify when we upgrade our libp2p deps

ramfox commented 6 years ago

Would love feedback/debate @b5 @dustmop @osterbit @rgardaphe

ramfox commented 6 years ago

Would love a final review!

ramfox commented 6 years ago

@dustmop @osterbit

Need approval by another core team member before I can merge :)

Let me know if there are any other issues or if I am good to gooooooo

b5 commented 6 years ago

🎉 🌮 🎉 🌮 🎉 🌮 🎉 🌮 🎉 🌮 🎉 🌮 🎉 🌮 🎉 🌮