search

qri-io / rfcs

Request For Comments (RFCs) documenting changes to Qri
MIT License
12 stars 6 forks source link

RFC: dataset naming #6

Closed b5 closed 6 years ago

b5 commented 6 years ago

This looks great to me! As the author I can't approve, but would love it if others could have a quick look. Let's push the merge button

ramfox commented 6 years ago

V fun.

I like the change from peername to handle!!!

One thing, a few locations use the term user, and previously we have been avoiding the term user in favor of peer. Specifically in lines 39, 45, and 127 (I'm not including the phrase 'user-friendly', as that does not relate to the concept of peer that we use in the codebase and docs. Any objection to changing those over, so they match other docs?

b5 commented 6 years ago

Yeah might as well not introduce more language. I'll update user -> peer...

ramfox commented 6 years ago

💅 💇 🥇