search

qrilka / xlsx

Simple and incomplete Excel file parser/writer
MIT License
130 stars 64 forks source link

Extract "Format" and "NumberFormat" to a separate file #121

Closed Anarchist666 closed 3 years ago

qrilka commented 6 years ago

And what's the point? Have you seen build errors?

Anarchist666 commented 6 years ago

And what's the point?

I want to add a high-level type "NamedStyle". And i'm going to move all hi-level types, such as "Format", "NumberFormat", "NamedStyle" into a separate file.

Have you seen build errors?

It was tested with ghc 8.2 and 8.4 without any errors.

qrilka commented 6 years ago

I have only 1 point about this refactoring - it appears that it's more logical to have StyleSheet as a part of Styles, as a submodule or even as a part of it. Having both Styles and StyleSheet at the same time looks confusing.

Anarchist666 commented 6 years ago

or even as a part of it.

Ok. It'll be great.

qrilka commented 5 years ago

@Anarchist666 are you still working on this?

qrilka commented 3 years ago

@Anarchist666 please raise your voice if you're against closing this one, we could reopen this then