search

qrilka / xlsx

Simple and incomplete Excel file parser/writer
MIT License
128 stars 62 forks source link

Depend on microlens instead of lens? #129

Closed unhammer closed 3 years ago

unhammer commented 4 years ago

Microlens has a quite a bit smaller dependency footprint than lens, but is often a drop-in replacement. See https://github.com/fosskers/microlens-aeson/#microlens-aeson for a visual comparison of the *-aeson versions. Would it be possible to have xlsx depend on microlens instead? It'd shorten our clean-build times quite a bit :)

qrilka commented 4 years ago

I think the library doesn't use advanced features of lens so should be compatible with microlens but I don't think there is enough motivation to change the default lens library. Quite a lot of applications use it already or it could come with some other dependency. But I'm OK with having a Cabal flag with which lens could be replaced with microlens if that won't change API significantly

qrilka commented 3 years ago

@unhammer I think this was resolved in 0.8.2 by #133

unhammer commented 3 years ago

Awesome =D