search

qrilka / xlsx

Simple and incomplete Excel file parser/writer
MIT License
132 stars 64 forks source link

Fix Accumulating Cell Merge Info While formatWorkbook #143

Closed vst closed 1 year ago

vst commented 3 years ago

This PR closes #142.

formatWorkbook accumulates cell merge information (_formattingMerges) along with style information as it iterates over a list of worksheet data.

Indeed, this is necessary for formatCell to process a single worksheet and to conclude with a list of cell ranges for merged cells.

However, once we are done with processing a single worksheet, we should reset the accumulated merge information to an empty list so that the next worksheet does not contain cell merges accumulated from previous worksheets' data.

qrilka commented 1 year ago

@vst I'm going to close this PR as no longer active, please shout if you need it to be reopened

vst commented 1 year ago

Alright. Sorry, I did not have time to look into that. I will ping you if I can look at it.