search

qrilka / xlsx

Simple and incomplete Excel file parser/writer
MIT License
128 stars 62 forks source link

Be Excel-compatible when handling pre 1900-03-01 dates #146

Closed MarceloZabini closed 2 years ago

MarceloZabini commented 2 years ago

This hopefully fixes #145. Although this should bring us closer to Excel, it does break compatibility, so it's probably worth mentioning in the changelog?

Thanks for your work and please let me know any changes you might want!

MarceloZabini commented 2 years ago

I forgot to attach a screenshot of Online Excel that may or may not help reviewing. Cells in the same row are equal but with different formatting:

image

MarceloZabini commented 2 years ago

I added an entry in the changelog but I don't know how you want to handle versioning, so feel free to change, suggest a change or just ask me to change something there.

qrilka commented 2 years ago

Sorry, was a bit busy - I plan to take a look into it this evening

qrilka commented 2 years ago

I think your change makes sense, I want to release a new version with #144 merged so could change the version but that's not done yet.