qrilka / xlsx

Simple and incomplete Excel file parser/writer
MIT License
132 stars 64 forks source link

Add newtype for column and row indexes #148

Open jappeace opened 3 years ago

jappeace commented 3 years ago

This will allow us to create smart constructors that check for values < 1. These causes issues in excel (nasty warnings which give users the impression they're being hacked!) Furthermore new types around these will no longer cause accidental confusion between rows and columns.

See discussion: https://github.com/qrilka/xlsx/pull/144/files#r693388304