search

qrilka / xlsx

Simple and incomplete Excel file parser/writer
MIT License
132 stars 64 forks source link

feat(cellRange,dataValidation): add support for cell range <dataValidation type="list"> and absolute coordinates #157

Closed flhorizon closed 2 years ago

flhorizon commented 2 years ago

Closes https://github.com/qrilka/xlsx/issues/156

Basically when I needed to implement flavours of mkRange mkSingleCellRef and matching from* functions, I've kept historical behaviour and types and instead wrote "prime" variants mkRange' etc

qrilka commented 2 years ago

Hi @flhorizon Thanks for contributions, I'm back from my vacation so should have some time to review them. In this case - would you mind splitting warnings-related changes from "real" code? It doesn't help to review them both in the same PR. Thanks

flhorizon commented 2 years ago

Hi @qrilka ! Thank you for your time. I've removed the commit about warnings for both my PRs. Are you interested in it for another PR? It mostly affects /test

qrilka commented 2 years ago

Sure, why not, even small improvement counts

qrilka commented 2 years ago

Please also take care of the name clash with microlens

flhorizon commented 2 years ago

Hi @qrilka !

I've done the 2 last changes you asked for and moved CellRef test definitions to a separate module

qrilka commented 2 years ago

Thanks