The parseComment function parses everything except for visibility, and then ends with return (ref, Comment txt author True). This PR changes the function so that it also parses visibility and then ends with return (ref, Comment txt author visibility)
Seems like this got through the previous test because there was only a case for when comments are visible, but not for when comments are invisible. So this PR also makes 1 of the 2 visible comments in the test invisible. Side note: the r function doesn't support variable interpolation, so "True" and "False" have been hardcoded into testComments. Therefore, there is an assumption that 'tshow False' and 'tshow True' will always evaluate to "False" and "True" respectively, although this seems like a relatively safe assumption.
qrilka
commented
1 year ago
The parseComment function parses everything except for visibility, and then ends with
return (ref, Comment txt author True). This PR changes the function so that it also parses visibility and then ends withreturn (ref, Comment txt author visibility)Seems like this got through the previous test because there was only a case for when comments are visible, but not for when comments are invisible. So this PR also makes 1 of the 2 visible comments in the test invisible. Side note: the r function doesn't support variable interpolation, so "True" and "False" have been hardcoded into testComments. Therefore, there is an assumption that 'tshow False' and 'tshow True' will always evaluate to "False" and "True" respectively, although this seems like a relatively safe assumption.