1.18 Post Merge Irregular Behaviour

qruet commented 2 years ago

Server Version 1.18-R0.1-SNAPSHOT

Plugin Version 3.6-b71

Describe the bug

Experience Cost bar does not properly update when actual result cost changes. (see media below)
The Enchantment Cost does not properly update either, forcing an inventory update (e.g. clicking the inventory) is necessary to update the displayed Repair Cost.
After a repair, clicking the repaired item disappears and then reappears when another inventory slot is clicked. I believe this is from the cursor item slot not being updated (missing packet).

To Reproduce

I used a diamond sword with an enchantment book with Sharpness V. Simply by going through the process with and without experience will be able to reproduce these issues.

Media

Gaming32 commented 2 years ago

Are there any errors in the console?

qruet commented 2 years ago

No stacktrace to report. I believe all of these issues are simply a result from missing packets or packets with the wrong data being sent. I would look into PacketPlayOutSetSlot which is constructed in IContainerAnvilLot#sendSlotUpdate and make sure the parameters haven't change order or something weird - perhaps the wrong data is being passed. Then also check that the updated repair cost for ContainerAnvil is being sent to the player as well, since the TooExpensiveBar is reading the correct cost but the GUI seems to be having trouble updating the repair cost.

qruet / AnvilLot

1.18 Post Merge Irregular Behaviour #23