search

qruto / laravel-wave

Painless Laravel Broadcasting with SSE
MIT License
724 stars 30 forks source link

Fix Documentation authEndpoint is required #67

Closed glwbr closed 2 months ago

glwbr commented 3 months ago

If the option is given, then authEndpoint is actually required.

slavarazum commented 3 months ago

https://github.com/qruto/laravel-wave-client/blob/main/src/wave-broadcaster.ts#L21

As you can see, options merges with appropriate order, so authEndpoint has default value.

Do you have any specific issue with this?

glwbr commented 3 months ago

@slavarazum Not a problem, It's that if you pass the options to new Wave() you'd also have to pass authEndpoint but right now the README says it's optional: Example

slavarazum commented 2 months ago

Oh, yes! It was previously marked as required in the client library, but it is now optional. client release

Thanks for participating 🤝