search

qsbase / qs

Quick serialization of R objects
400 stars 19 forks source link

rpois arguments #32

Closed r2evans closed 4 years ago

r2evans commented 4 years ago

In your vignette and tests, you use rpois(100, 5e6) along with rnorm(5e6). The call to rpois is producing only 100 random samples; data.frame won't complain because 100 cleanly recycles into 5e6.

(I doubt this has any influence on the benchmark or results, but the code is inconsistent.)

traversc commented 4 years ago

Thanks for pointing that out. Will be sure to fix it next time ;)

traversc commented 4 years ago

Hey, I fixed that typo and took the opportunity to update the benchmark. Should be on CRAN as well.