Feature - Githubissues

qsharp-community / qram

Library for Q# implementing various qRAM proposals

MIT License

52 stars 17 forks source link

Feature #12

Closed shikharsingh3 closed 4 years ago

shikharsingh3 commented 4 years ago

Need to fix the error in src folder.

crazy4pi314 commented 4 years ago

A couple of things b4 I can review this:

[ ] Please update the description of the PR to indicate what functionality you are adding.
[x] Update your branch to current master
[ ] Comment/add API documentation to you code so we can follow what you are doing. Also remove code that is not being used.
[ ] Please adhere to the Q# style guide for code formatting

glassnotes commented 4 years ago

To add to @crazy4pi314 's comment, there are some general guidelines for submitting a PR here. There are also contribution guidelines in the repo.

crazy4pi314 commented 4 years ago

A couple of things b4 I can review this:

[ ] Please update the description of the PR to indicate what functionality you are adding.

[x] Update your branch to current master

[ ] Comment/add API documentation to you code so we can follow what you are doing. Also remove code that is not being used.

[ ] Please adhere to the Q# style guide for code formatting

After a detailed review, three of the four items listed here still are not done, can you please address them? Thanks!