util:math:sphharmonics: fix build failure with GCC-11

qsimulate-open / bagel

Brilliantly Advanced General Electronic-structure Library

GNU General Public License v3.0

92 stars 44 forks source link

util:math:sphharmonics: fix build failure with GCC-11 #237

Closed slyon closed 2 years ago

slyon commented 2 years ago

sphharmonics.cc Fails to build with C++17 due to the ambiguous variable name legendre, that is now also defined in the std:: namespace (imported as using std;).

Changing the local variable name fixes the issue.

shiozaki commented 2 years ago

Thanks for reporting - this has actually been fixed in the QSimulate version but was not backported to the open version here. To avoid complication with copyrights (to merge a PR I need a copyright assignment doc to be signed), I will close this PR and make a commit that solves this issue.