search

qsniyg / maxurl

Finds larger/original versions of images and videos
https://qsniyg.github.io/maxurl/
Apache License 2.0
1.08k stars 65 forks source link

i.ytimg.com is not changed to max resolution #29

Open speedymaan opened 5 years ago

speedymaan commented 5 years ago

For example: https://i.ytimg.com/vi/sxItyrp55g8/0.jpg -> https://i.ytimg.com/vi/sxItyrp55g8/maxresdefault.jpg

qsniyg commented 5 years ago

It is in the codebase, but there are cases where the max resolution image is, for some reason, different than the smaller image, so I disabled it for now.

What I think I'll do is that I'll create an option for enabling "experimental" or "broken" rules, which would include rules that could potentially change the image, like this one.

qsniyg commented 5 years ago

The issue is now fixed in https://github.com/qsniyg/maxurl/commit/c80520fbf1717952b0dcaf8359dc75523a237b28 :) Make sure to enable "Possibly different images" in the settings.

DevWannabe-dot commented 2 years ago

I potentially don't know what causes this, but for the first time in my life I've came across img.youtube.com and image max url does nothing but loading non-stop. Maybe that's not even the same issue, but it was what I found in a comment, so, the working rule should be:

smaller: https://img.youtube.com/vi/2NbC8kGGNus/0.jpg original: https://i.ytimg.com/vi/2NbC8kGGNus/maxresdefault.jpg or https://i.ytimg.com/vi/2NbC8kGGNus/sddefault.jpg or https://i.ytimg.com/vi/2NbC8kGGNus/hqdefault.jpg

hope this helps :) tried refreshing already

qsniyg commented 2 years ago

Thank you for reminding me! Yes I need to fix the Youtube rule, it crashes at the moment.

I believe the blocker was that it was a bug in the bigimage_recursive family of functions (the functions that process the rule output) rather than the rule itself.

pointydev commented 2 years ago

I'd love to see this issue resolved, especially since there are now large query strings associated with video thumbnails, meaning manually changing to maxresdefault requires more hand-eye coordination.