search

qsniyg / maxurl

Finds larger/original versions of images and videos
https://qsniyg.github.io/maxurl/
Apache License 2.0
1.12k stars 69 forks source link

Android add-on or Android app #500

Open DonaldTsang opened 4 years ago

DonaldTsang commented 4 years ago

Currently, the Firefox (Android version) will not allow the installation of this Firefox Add-on, which it claims to be desktop only.

Is it possible to make this a separate application? And possibly combine this with https://github.com/dessant/search-by-image ?

qsniyg commented 4 years ago

the Firefox (Android version) will not allow the installation of this Firefox Add-on

I'm guessing this is due to their new version only allowing addons that they've explicitly approved (as far as I can see, there doesn't appear to be any way to submit it for approval). Recent (since ~a year ago or so) versions of the addon are uploaded with support for android flagged, but I'm guessing this option is ignored in the new firefox app. That being said, I only tested it under genymotion once, so perhaps there's also something I've messed up since...

Is it possible to make this a separate application?

As written in discord, I'm not at all against this idea (and I definitely see the use), but I don't personally own an android phone, and am pretty much entirely oblivious to the whole mobile ecosystem.

If anyone else would be willing to take up this idea, either create their own app for it, or work with me to create an "official" (I guess) app for it, let me know, I'd be more than willing to help wherever I can. As written in the readme, it also functions as a node.js library, and should be relatively easy to integrate. There are a few complications I can think of (e.g. with updates), but I'm sure they could be worked out.

And possibly combine this with https://github.com/dessant/search-by-image

Yes, see https://github.com/qsniyg/maxurl/issues/172. As written in the issue, I believe one solution could be to kind of copy the way Imagus and other addons do it, which is basically a "send to" feature, which is also what the addon you linked seems to be doing as well. It shouldn't be too difficult to implement (though there are a few complications that haven't yet been sorted out, e.g. submenus, in order to choose which search engine to send it to, or all search engines, etc.), I just haven't yet gotten around to it.

Jon8RFC commented 1 year ago

Here's a workaround, which allows for any and all add-ons to be installed in firefox on android: https://www.androidpolice.com/install-add-on-extension-mozilla-firefox-android/

And I went into the firefox menu>Add-ons>Image Max URL>options>popup, and set the popup trigger to be "mouseover".

There is no mouseover/hover functionality on Pixels (there was mouseover/hover on my old Galaxy s4), so a tap & hold, then backing out of the firefox popup (open image in new tab, etc) allows the maxurl html popup to show itself.

What would be awesome would be if the standard "Try to find larger image" menu option was integrated into the firefox native pop-up menu when tapping & holding as well. That's not something I have any knowledge of, but I'll read up on it.