qsniyg / maxurl

Finds larger/original versions of images and videos
https://qsniyg.github.io/maxurl/
Apache License 2.0
1.09k stars 66 forks source link

instagram username not supporting dots #718

Closed ghost closed 3 years ago

ghost commented 3 years ago

When I use popup on this instagram post: https://www.instagram.com/p/9bjNTgQrvm/ and this file name preset: {author_username} {id} , and save (default action of popup) there is name showing only as "gg", meaning looks like dot damages whole file naming scheme?

qsniyg commented 3 years ago

See if https://github.com/qsniyg/maxurl/commit/1e019037c5cd098b266b73a0192d4be86789fa4a fixes it :)

(I haven't tested it yet, testing IG's a bit of a pain, but it should in theory work)

ghost commented 3 years ago

Does not work. To clarify it is giving me file name gg instead of gg.swimwear 9bjNTgQrvm (excluding the extension jpg of course) when file name template is {author_username} {id}

qsniyg commented 3 years ago

See if https://github.com/qsniyg/maxurl/commit/aad3777202a0d9a2de4f65a00b27e4a7b80a82a5 fixes it. I haven't tested it under IG, but I did a synthetic test with the values you provided for {author_username} and {id}.

I can't actually replicate the exact issue under chrome, but with the new commit, it'll always append the correct extension, instead of chrome believing that swimwear 9bjNTgQrvm is the file extension. I'll test under firefox soon.

ghost commented 3 years ago

Still does not work. Actually you can test this without Instagram too, it happens on any Instagram image also when you set this for filename rule: gg.swimwear {id} or on any image if gg.swimwear e.g. on this one: https://veracrypt.fr/en/VeraCrypt128x128.png

qsniyg commented 3 years ago

Can you send your settings? I just tried under Firefox, setting gg.swimwear as the filename format with the link you sent, and it downloaded as gg.swimwear.png.

Also, just to make sure, are you running the latest git version, and do you have only one version installed? (if you have more than one version installed, such as having the extension and the userscript, it can cause unpredictable behavior)

ghost commented 3 years ago

Yes. I am using last userscript.user.js file directly downloaded from github recently and replaced in last extension xpi file. And unsigned addons enabled. I am not using Git. Settings:

{"imu_enabled":true,"language":"en","check_updates":true,"check_update_interval":24,"check_update_notify":false,"dark_mode":false,"settings_tabs":true,"settings_alphabetical_order":false,"settings_visible_description":true,"settings_show_disabled":true,"settings_show_disabled_profiles":false,"settings_show_requirements":true,"advanced_options":false,"allow_browser_request":true,"retry_503_times":3,"retry_503_ms":2000,"use_blob_over_arraybuffer":false,"allow_live_settings_reload":true,"allow_remote":true,"disable_keybind_when_editing":true,"enable_gm_download":true,"gm_download_max":15,"enable_webextension_download":false,"write_to_clipboard":false,"redirect":true,"redirect_video":true,"redirect_audio":false,"redirect_history":true,"redirect_extension":true,"canhead_get":true,"redirect_force_page":false,"redirect_infobox_url":false,"redirect_infobox_timeout":7,"print_imu_obj":false,"redirect_disable_for_responseheader":false,"redirect_to_no_infobox":false,"redirect_host_html":false,"mouseover":true,"mouseover_open_behavior":"download","t2_mouseover_open_behavior":"popup","t3_mouseover_open_behavior":"popup","mouseover_trigger_behavior":"keyboard","mouseover_trigger_key":[["a","s"]],"mouseover_trigger_key_t2":[],"mouseover_trigger_key_t3":[],"mouseover_trigger_delay":1,"mouseover_trigger_mouseover":false,"mouseover_trigger_enabledisable_toggle":"disable","mouseover_trigger_prevent_key":["shift"],"mouseover_close_behavior":"esc","mouseover_close_need_mouseout":true,"mouseover_jitter_threshold":30,"mouseover_cancel_popup_when_elout":true,"mouseover_cancel_popup_with_esc":true,"mouseover_cancel_popup_when_release":true,"mouseover_auto_close_popup":false,"mouseover_auto_close_popup_time":5,"mouseover_hold_key":["i"],"mouseover_hold_position_center":false,"mouseover_hold_close_unhold":false,"mouseover_hold_unclickthrough":true,"mouseover_close_el_policy":"both","mouseover_close_click_outside":false,"mouseover_allow_partial":"media","mouseover_partial_avoid_head":false,"mouseover_use_blob_over_data":false,"popup_use_anonymous_crossorigin":false,"mouseover_enable_notallowed":true,"mouseover_enable_notallowed_cant_load":true,"mouseover_notallowed_duration":300,"mouseover_minimum_size":20,"mouseover_exclude_backgroundimages":false,"mouseover_exclude_page_bg":true,"mouseover_exclude_imagemaps":true,"mouseover_only_links":false,"mouseover_linked_image":false,"mouseover_exclude_sameimage":false,"mouseover_exclude_imagetab":true,"mouseover_allow_video":true,"t2_mouseover_allow_video":true,"t3_mouseover_allow_video":true,"mouseover_allow_audio":false,"t2_mouseover_allow_audio":false,"t3_mouseover_allow_audio":false,"mouseover_allow_hlsdash":false,"t2_mouseover_allow_hlsdash":true,"t3_mouseover_allow_hlsdash":true,"enable_stream_download":false,"stream_mux_mp4_over_mkv":false,"hls_dash_use_max":true,"max_video_quality":null,"mouseover_video_autoplay":true,"mouseover_video_controls":false,"mouseover_video_controls_key":["c"],"mouseover_video_loop":true,"mouseover_video_autoloop_max":0,"mouseover_video_playpause_key":["space"],"mouseover_video_muted":false,"mouseover_video_mute_key":["m"],"mouseover_video_volume":100,"mouseover_video_volume_down_key":["9"],"mouseover_video_volume_up_key":["0"],"mouseover_video_volume_change_amt":5,"mouseover_video_resume_from_source":false,"mouseover_video_resume_if_different":false,"mouseover_video_pause_source":true,"mouseover_video_seek_amount":10,"mouseover_video_seek_left_key":["shift","left"],"mouseover_video_seek_right_key":["shift","right"],"mouseover_video_frame_prev_key":[","],"mouseover_video_frame_next_key":["."],"mouseover_video_framerate":25,"mouseover_video_speed_down_key":["["],"mouseover_video_speed_up_key":["]"],"mouseover_video_speed_amount":0.25,"mouseover_video_reset_speed_key":["backspace"],"mouseover_video_screenshot_key":["shift","s"],"popup_video_screenshot_format":"png","mouseover_ui":true,"mouseover_ui_toggle_key":["u"],"mouseover_ui_opacity":80,"mouseover_ui_use_safe_glyphs":false,"mouseover_ui_imagesize":true,"mouseover_ui_zoomlevel":true,"mouseover_ui_filesize":false,"mouseover_ui_gallerycounter":true,"mouseover_ui_gallerymax":50,"mouseover_ui_gallerybtns":true,"mouseover_ui_closebtn":true,"mouseover_ui_optionsbtn":false,"mouseover_ui_downloadbtn":false,"mouseover_ui_rotationbtns":false,"mouseover_ui_caption":true,"mouseover_ui_wrap_caption":true,"mouseover_ui_caption_link_page":true,"mouseover_ui_link_underline":true,"mouseover_use_remote":false,"mouseover_zoom_behavior":"fit","mouseover_zoom_custom_percent":100,"mouseover_zoom_use_last":"gallery","mouseover_zoom_max_width":0,"mouseover_zoom_max_height":0,"mouseover_pan_behavior":"drag","mouseover_movement_inverted":true,"mouseover_drag_min":5,"mouseover_scrolly_behavior":"zoom","mouseover_scrollx_behavior":"gallery","mouseover_scrolly_video_behavior":"default","mouseover_scrolly_video_invert":false,"mouseover_scrollx_video_behavior":"default","scroll_override_page":false,"scroll_zoom_origin":"cursor","scroll_zoom_behavior":"fitfull","scroll_incremental_mult":1.25,"mouseover_move_with_cursor":false,"mouseover_move_within_page":true,"zoom_out_to_close":false,"scroll_past_gallery_end_to_close":false,"mouseover_position":"cursor","mouseover_prevent_cursor_overlap":true,"mouseover_overflow_position_center":false,"mouseover_overflow_origin":"a11","mouseover_add_link":true,"mouseover_add_video_link":false,"mouseover_click_image_close":false,"mouseover_click_video_close":false,"mouseover_download":false,"mouseover_hide_cursor":false,"mouseover_hide_cursor_after":0,"mouseover_mouse_inactivity_jitter":5,"mouseover_clickthrough":false,"mouseover_mask_ignore_clicks":false,"mouseover_links":true,"mouseover_only_valid_links":true,"mouseover_allow_self_pagelink":false,"mouseover_allow_iframe_el":false,"mouseover_allow_canvas_el":false,"mouseover_allow_svg_el":false,"mouseover_enable_gallery":true,"mouseover_gallery_cycle":false,"mouseover_gallery_prev_key":["left"],"mouseover_gallery_next_key":["right"],"mouseover_gallery_move_after_video":false,"mouseover_gallery_download_key":["shift","d"],"gallery_download_method":"zip","gallery_download_unchanged":true,"gallery_zip_filename_format":"{host_domain_nosub}-{items_amt}-{download_unix}\n{items_amt}-{download_unix}","gallery_jd_autostart":false,"gallery_zip_add_tld":true,"gallery_zip_add_info_file":true,"mouseover_styles":"","mouseover_enable_fade":true,"mouseover_enable_zoom_effect":false,"mouseover_zoom_effect_move":false,"mouseover_fade_time":100,"mouseover_enable_mask_styles2":"never","mouseover_mask_styles2":"background-color: rgba(0, 0, 0, 0.5)","mouseover_mask_fade_time":100,"mouseover_ui_styles":"","mouseover_wait_use_el":false,"mouseover_add_to_history":false,"mouseover_close_key":["esc"],"mouseover_download_key":[["s"],["ctrl","s"]],"mouseover_open_new_tab_key":["o"],"mouseover_open_bg_tab_key":["shift","o"],"mouseover_copy_link_key":["shift","c"],"mouseover_open_options_key":["p"],"mouseover_open_orig_page_key":["n"],"mouseover_rotate_left_key":["e"],"mouseover_rotate_right_key":["r"],"mouseover_flip_horizontal_key":["h"],"mouseover_flip_vertical_key":["v"],"mouseover_zoom_in_key":[["+"],["="],["shift","="]],"mouseover_zoom_out_key":[["-"]],"mouseover_zoom_full_key":["1"],"mouseover_zoom_fit_key":["2"],"mouseover_fullscreen_key":["f"],"mouseover_apply_blacklist":true,"apply_blacklist_host":false,"mouseover_matching_media_types":false,"mouseover_find_els_mode":"hybrid","popup_allow_cache":true,"popup_cache_duration":30,"popup_cache_itemlimit":20,"popup_cache_resume_video":true,"website_inject_imu":true,"website_image":true,"extension_contextmenu":true,"extension_hotreload":true,"allow_watermark":false,"allow_smaller":false,"allow_possibly_different":false,"allow_possibly_broken":false,"allow_possibly_upscaled":false,"allow_thirdparty":false,"allow_apicalls":true,"allow_thirdparty_libs":true,"custom_xhr_for_lib":true,"use_webarchive_for_lib":false,"lib_integrity_check":true,"allow_thirdparty_code":false,"allow_bruteforce":false,"process_format":{},"deviantart_prefer_size":false,"deviantart_support_download":true,"ehentai_full_image":true,"imgur_filename":false,"imgur_source":false,"instagram_use_app_api":true,"instagram_dont_use_web":false,"instagram_prefer_video_quality":true,"instagram_gallery_postlink":false,"snapchat_orig_media":true,"tiktok_no_watermarks":false,"tiktok_thirdparty":null,"tumblr_api_key":"xrMpLM8n1eCeL3oRYSZG7CLALw6EHhYDdU6Wq5eD1PbMkld7Y1","twitter_use_ext":false,"bigimage_blacklist":"","bigimage_blacklist_engine":"glob","filename_format":"gg.swimwear","replaceimgs_enable_keybinding":false,"replaceimgs_keybinding":["shift","alt","r"],"replaceimgs_auto":false,"replaceimgs_replaceimgs":true,"replaceimgs_addlinks":false,"replaceimgs_replacelinks":false,"replaceimgs_plainlinks":"none","replaceimgs_links_newtab":false,"replaceimgs_remove_size_constraints":false,"replaceimgs_usedata":false,"replaceimgs_wait_fullyloaded":true,"replaceimgs_totallimit":8,"replaceimgs_domainlimit":2,"replaceimgs_delay":0,"replaceimgs_css":"","replaceimgs_simple_progress":true,"highlightimgs_enable_keybinding":false,"highlightimgs_keybinding":["shift","alt","h"],"highlightimgs_enable":false,"highlightimgs_auto":"never","highlightimgs_onlysupported":true,"highlightimgs_css":"outline: 4px solid yellow","last_update_check":1619738021324,"last_update_version":"0.18.3","last_update_url":null,"settings_version":10}

No, I don't have other extensions like Greasemonkey. Also I tried disabling all other extensions and restarting browser. Also tried using default popup keys shortcut.

ghost commented 3 years ago

Oh, sorry, looks like now it works. I just tried downloading whole code and side load into chrome and noticed it works. Then used same userscript.user.js file from there and replaced in xpi file, and now it works in Firefox too. Looks like I was outdated few hours, last file which did not work was from 10:48 AM GMT time. Also noticed via WinMerge file had 40 lines different, so definitely did not have the newest. A lot changed in few hours. Newer works perfectly, thanks for fixing.