search

qspin / qtaste

[NEW RELEASE VERSION 3.0.0] The QTaste is an open-source functional and non-functional test environment offering services to developers and testers. It has been implemented following a data driven testing philosophy.
http://www.qtaste.org
GNU Lesser General Public License v3.0
6 stars 11 forks source link

Cannot cancel a manual testbed start #116

Open dergo opened 10 years ago

dergo commented 10 years ago

A manual testbed start, i.e. clicking on "(Re)start testbed" with "Ignore control script" checked cannot be cancelled, which is quite annoying since a testbed start can be several minutes long!

nfac commented 9 years ago

Feature added.

To be validated.

dergo commented 9 years ago

Tested successfully.

Note that if we click on stop during a SUT start, we see that GUI is not updated during the call to stop, only when it is finished... maybe some stuff is executed in Swing thread while it shouldn't. I added this note in issue #123, so I close this issue because it will be handled in that other issue.

dergo commented 9 years ago

There's a race-condition in code (not so easy to reproduce). Sometimes, after having canceled a SUT start, if you restart the SUT, it is also canceled, without clicking again on the stop button.

15:05:36 INFO QTaste com.qspin.qtaste.kernel.engine.TestEngine Test aborted by user 15:05:36 INFO QTaste com.qspin.qtaste.kernel.engine.TestEngine Cancel start/stop SUT 15:05:36 INFO QTaste com.qspin.qtaste.kernel.engine.TestEngine Stopping SUT using command 'Testbeds/ControlScripts/playback.py stop ' 15:05:37 INFO QTaste org.apache.log4j.net.SocketNode Caught java.io.EOFException closing conneciton. 15:05:38 INFO QTaste com.qspin.qtaste.kernel.engine.TestEngine SUT start command cancelled 15:05:39 INFO QTaste org.apache.log4j.net.SocketNode Caught java.io.EOFException closing conneciton. 15:05:39 INFO QTaste com.qspin.qtaste.kernel.engine.TestEngine Stopping SUT using command 'Testbeds/ControlScripts/playback.py stop ' 15:05:40 INFO QTaste com.qspin.qtaste.kernel.engine.TestEngine SUT stopped 15:05:40 INFO QTaste com.qspin.qtaste.kernel.engine.TestEngine SUT stop command cancelled

Also the "SUT stopped" log message sometimes appears after that restart button is re-enabled.

dergo commented 9 years ago

Also when I cancel a (re)start, the SUT is being stopped but the GUI buttons (restart/stop, ignore control script) are re-enabled before the SUT is completely stopped.