search

qstrahl / vim-matchmaker

Highlight matches for the word under the cursor
38 stars 10 forks source link

Added custom background color #22

Closed alanmesquita closed 7 years ago

alanmesquita commented 7 years ago

Sometimes we need to use custom colors like truecolors, or just for fun. I want to change Matchmaker background color in vim configs. I would like to suggest this change, what do you think? Please review and give me the feedback.

mvoto commented 7 years ago

I have tried this suggested color on highlight line with truecolors and looks much better than the white one. This can be a simple but significant change :+1:

tommcdo commented 7 years ago

This can already be done by overriding the Matchmaker highlight group, which offers more customization than just the GUI background color. This is documented under :help matchmaker-highlight.

qstrahl commented 7 years ago

@alanmesquita @mvoto Your thoughts on what @tommcdo said? I'm inclined to close this PR but want to hear from you first.

alanmesquita commented 7 years ago

I understood @tommcdo, usually in the vim plugin I do something like g: something = 1 and I thought it would be simpler to have it too. Thanks a lot for the feedback, this plugin though simple is very useful to me. Yes, I understand @qstrahl, thanks for the feedback.

qstrahl commented 7 years ago

All right, I'll close this then