search

qt-labs / vstools

Other
73 stars 23 forks source link

Modified for -no-zstd support in rcc and OpenGLWidgets module in Qt6 #7

Closed dwsdolce closed 1 year ago

dwsdolce commented 1 year ago

The modules list for qt6 did not include OpenGLWidgets. This has been added. The resource compiler properties did not allow for --no-zstd which is generated by default by qmake with the community download of qt6. Both of these caused conversions and builds to fail.

kaheimri commented 1 year ago

Many thanks for your patches. I've had to adapt the patch for --no-zstd a bit, nevertheless both patch are now up for review on Qt Code Review. It would be nice if you can close the pull-request, cause all code contribution needs to go thru our code review tool.

dwsdolce commented 1 year ago

Interesting. Not sure why qtrcc.xml is not required since it is not generated. Guess I have a bit more research into what the _v3 stands for.

Closing the pull-request.

Regards David

kaheimri commented 1 year ago

We are using T4 Text Templates during the initial run 'vstools -init' to generate some code specific to the VS version in use. This applies to all files with '_TT' extension except for 'AssemblyInfo.cs'.

Br, Karsten

dwsdolce commented 1 year ago

Thanks, I did see that templates were being used. What I found is that for QtVs projects greater or equal to 300 then the generated qtrcc_v3.xml is used otherwise the qtrcc.xml is used. So, I think I found the answer to my question. I just had to dig into the template and C# code a little more and see where QtVSProjectVersion was coming from. And we are at qtProjectFormatVersion 304 per Resources.cs. Therefore the qtrcc.xml is NOT used with a project generated using the latest vstools.

Thank you for your time. I appreciate it.

Regards David

From: kaheimri @.> Sent: Wednesday, December 14, 2022 12:32 AM To: qt-labs/vstools @.> Cc: David Smith @.>; State change @.> Subject: Re: [qt-labs/vstools] Modified for -no-zstd support in rcc and OpenGLWidgets module in Qt6 (PR #7)

We are using T4 Text Templateshttps://learn.microsoft.com/en-us/visualstudio/modeling/code-generation-and-t4-text-templates?view=vs-2022 during the initial run 'vstools -init' to generate some code specific to the VS version in use. This applies to all files with '_TT' extension except for 'AssemblyInfo.cs'.

Br, Karsten

— Reply to this email directly, view it on GitHubhttps://github.com/qt-labs/vstools/pull/7#issuecomment-1350628369, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALM7BKEYBQX56VIVLMBLPKLWNGAWTANCNFSM6AAAAAASYUDMXU. You are receiving this because you modified the open/close state.Message ID: @.**@.>>

kaheimri commented 1 year ago

Hi David, you where right about the pre-300 project format. The unfortunate thing is I applied your patch on my current working tree where we already removed support for this old project format. I've updated the patch-set to include it again. Thank you for coming back to me so that I could discover my mistake.

Regards, Karsten