search

qt3uw / qt3-utils

Data Acquisition for Confocal Microscope and Spin Control Experiments
https://sites.google.com/uw.edu/qt3-lab/projects
BSD 3-Clause "New" or "Revised" License
3 stars 6 forks source link

Implement scanner interface to be used for CounterAndScanner object #79

Open gadamc opened 1 year ago

gadamc commented 1 year ago

Currently, the qt3utils.datagenerators.piezoscanner.CounterAndScanner object expects two objects at instantiation -- an object that returns counts and an object that controls the pizza. The expectation is that the piezo controller implements the functionality found in an external python package -- nipiezojenapy.BaseControl. It's probably better programming practice to define a generic interface within qt3utils and then implementations for specific controllers, such as for nipiezojenapy.PiezoControl. Then, if future controllers are used, we can write an implementation for that controller in qt3utils and immediately used in the CounterAndScanner object.

gadamc commented 1 year ago

This issue may be closed soon. I am leaning toward deprecating nipiezojenapy and just move all of that code into qt3-utils.