qtilities / wshot

Wayland screenshot tool using Qarma
GNU General Public License v3.0
1 stars 3 forks source link

Cumulative updates #2

Closed redtide closed 6 months ago

redtide commented 7 months ago

For practice I did a single PR, so it would make sense to use a rebase merge to avoid a single merge commit for all these. Let me know if I have to change/remove something.

redtide commented 6 months ago

I just made a force push to add the --window-icon option to display the app icon in the title bar (not to be confused with info/warning message dialogs' icon).

In Zenity manual it's defined to be used on all dialog types, but there is a bug so that it doesn't work with --forms (and some others): it doesn't warn nor reports an error, just not displayed silently.

However in Qarma it works as expected.

stefonarch commented 6 months ago

Thanks, nice. Ttitlebar in labwc doesn't support icons yet. There are some things to fix, could be done also afterwards:

redtide commented 6 months ago

I'm still under openbox, haven't tested it yet on labwc, but I expect it should/will work there as well someday.

stefonarch commented 6 months ago

Just tested under wayfire, it doesn't display it, but that's not a big deal. screen_area_lun_14:26:28_

redtide commented 6 months ago

is that zenity? Otherwise it's strange that it shows the generic icon using qarma. Anyway yes, if it doesn't causes problems it could work someday when things will be sorted out.