qtilities / wshot

Wayland screenshot tool using Qarma
GNU General Public License v3.0
1 stars 3 forks source link

To do list #5

Open stefonarch opened 5 months ago

stefonarch commented 5 months ago
redtide commented 4 months ago

Thinking of it the OK Cancel translation should be done from the application side (Qarma/Zenity should do that), so I think we can get rid of it. The --ok-label option looks odd to me if we can customize and translate the OK button but the cancel is not translated, and on that one it's not our job; for example Qt has its own translations to be loaded to translate buttons. Maybe open a feature request upstream?

I think the config options should be the same used for the UI (basically the translated ones, but using the variable names or similar as keys), so the default options are the same the UI is using when presented after run.

stefonarch commented 4 months ago

For some reason it doesn't even work here:

--ok-label="Take Screenshot" \
--cancel-label="Exit" \

Default Qt translations would be weird too here.

redtide commented 4 months ago

Qt is an example that it has already its own translations, to use them you need to initialize a Qt application to use them, in this case Qarma. In general I mean is not our job to translate buttons at all.