QtnPropertyQColorLineEditBttnHandler::onToolButtonClicked crash

qtinuum / QtnProperty

Extended properties for Qt5

Apache License 2.0

425 stars 154 forks source link

QtnPropertyQColorLineEditBttnHandler::onToolButtonClicked crash #47

Open sloanyyc opened 3 years ago

sloanyyc commented 3 years ago

editorBase() will destoryed which is QColorDialog's parent

why not use as flow

auto property = &this->property();
auto reason = delegate()->editReason();
QColorDialog dlg(property->value());
if (dlg.exec() == QDialog::Accepted)
{
    property->setValue(dlg.currentColor(), reason);
}

kusharami commented 3 years ago

Do you have an example application to reproduce the crash? I don't see what can be crashed there.