qtngo / homework_portfolio

0 stars 0 forks source link

Feedback for assignment #2 #2

Open barryross opened 8 years ago

barryross commented 8 years ago

FEWD Week #2 Project: Styling with CSS


Description

_Single-column landing page_ - Relaxr or your own

Student: Quoctruong Ngo

Project URL: https://github.com/qtngo/homework_portfolio/tree/master/assignment2

Technical Requirements Does Not Meet Expectations (0) Meets Expectations (1) Exceeds Expectations (2)
Use HTML5 structural elements (nav, header, footer) x
Use a CSS Reset file in addition to your style.css file to style the page x
Use IDs and Classes to to select and style elements on the page x
Style your text with the Google Fonts provided by your style guide x
Follow naming conventions, maintain consistency across .html and .css files and use best practices for naming IDs and Classes x
Indent nested elements to increase your code's readability x
TOTAL: 10/12
barryross commented 8 years ago

Hey Truong,

Awesome work on this assignment! Melissa and I are both so impressed by your creativity and the way you are tackling these assignments. You have gone above and beyond what the assignment was asking and are doing so many great things here. In addition to the concept being so creative, you are also tackling the requirements in creative and unique ways, incorporating things beyond what we've covered in class and are keeping your lines of code well commented in the process!

I really like the transitions and forms btw.

A couple points on some of the requirements:

As for naming conventions, please ise "-" for multiple words instead of "camelCase" in your HTML/CSS. It is convention to do multiple words "like-this" in HTML/CSS and "likeThis" in JavaScript.

Awesome job all around on this!