qtngo / homework_portfolio

0 stars 0 forks source link

Feedback for assignment 4 #4

Open barryross opened 8 years ago

barryross commented 8 years ago

FEWD Week #4 Project: JavaScript Basics


Description

The team from Relaxr is back...again! They want their page to be more interactive and asked you to add JavaScript to their source code. You've been given the HTML and CSS but will need to create a JavaScript file and add a few different pieces of interactivity: Users should be able to click a link and have the remainder of the blog's content slide down and appear on the page, both on the main content column and the side bar; users should also be able hide the content when they are finished reading. See a detailed technical explanation below.

Student: Quoctruong Ngo

Project URL: https://github.com/qtngo/homework_portfolio

Technical Requirements Does Not Meet Expectations (0) Meets Expectations (1) Exceeds Expectations (2)
Use in-line-block or floats in your CSS to achieve a two-column layout- Prevent a form submission with the event.preventDefault() function x
Use the $.ready() handler to delay your code from executing until all DOM assets have been loaded x
Select the appropriate DOM elements with CSS selectors upon a user's click using the $.click() handler x
Have the text in the <p>tag slide down along with a "Read Less" link in the blog post using,$.slideDown() and $.show() x
Hide the "Read More" link using $.hide() x
Have the <p> slide up and hide the "Read Less" link using $.slideUp() and $.hide() x
Show the "Read More" link using $.show() x
Using the same functions as above, if a user clicks the "Learn More" link in the sidebar, have the '' inside that '

' slide down and hide the "Learn More" link using $.slideDown() and $.hide()

x
TOTAL: 7/16
barryross commented 8 years ago

Hey Truong, so really great job being so creative with this assignment! You are doing some really awesome things here - I really like the unique look/feel of your site and the concept is very cool! One of the main things the assignment was asking in addition to using slideUp() and slideDown() was to hide() and show() elements...so, I had to give only partial or no credit for some of those related requirements because you were only using slideToggle() throughout, and no use of hide() or show(). I also noticed there was no use of inline-block or float so I had to leave off marks for that as well. That being said, you area also going above and beyond in many other ways, and I really think it's awesome how creative you are being. How might you be able to stay closer to the tech requirements and still be as creative as you want? That may be a fun challenge in itself. Please see inline comments for more info!