qtranslate / qtranslate-xt

qTranslate-XT (eXTended) - reviving qTranslate-X multilingual plugin for WordPress. A new community-driven plugin soon. Built-in modules for WooCommerce, ACF, slugs and others.
GNU General Public License v2.0
550 stars 103 forks source link

Field group title overwritten with ACF6 #1252

Closed herrvigg closed 1 year ago

herrvigg commented 1 year ago

There's a regression with ACF6 for the field group title. image

Only the last language is saved and it overwrites the others. Error in the console log when the page is loaded:

No form found for translatable field id= title

The problem with the new design is the title field is not a child item directly below the form... 😕 QT-XT doesn't send the current language being edited nor the hidden fields containing the title translations for each language.

Instead of following a usual HTML structure, ACF6 have a <input form="post" ... attribute. This allows to have a field detached from the form subtree. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#form

It is the first time this type of form structure is seen. It requires changes in the QTX Javascript code.

herrvigg commented 1 year ago

Fixed with #1253 which is a generic solution, not just for ACF6.

herrvigg commented 1 year ago

Released in 3.13.0.