qtranslate / qtranslate-xt

qTranslate-XT (eXTended) - reviving qTranslate-X multilingual plugin for WordPress. A new community-driven plugin soon. Built-in modules for WooCommerce, ACF, slugs and others.
GNU General Public License v2.0
545 stars 103 forks source link

[SLUGS] misc fixes #1363

Closed spleen1981 closed 9 months ago

spleen1981 commented 11 months ago

Bunch of fixes for slugs module:

spleen1981 commented 11 months ago

@herrvigg better "Rebase and merge" for this PR in case, for cleaner history.

sviluppomania commented 9 months ago

HI,

this solution resolves 2 reported BUGS:

1273

1373

Thank you.

janhn commented 9 months ago

This fixed an instance of #1358 for me (CRITICAL Uncaught TypeError: Argument 1 passed to QTX_Module_Slugs::get_page_by_path() must be of the type string, null given, called .../slugs.php on line 438 and defined in .../slugs.php:1039). Thanks.

herrvigg commented 9 months ago

Great with a lot of fixes, but the review and follow-up is made difficult by "squashing" all in a single commit. Since it's very different topics I would prefer separate fixes and merge them one by one. Let's go for a merge.