search

qtranslate / qtranslate-xt

qTranslate-XT (eXTended) - reviving qTranslate-X multilingual plugin for WordPress. A new community-driven plugin soon. Built-in modules for WooCommerce, ACF, slugs and others.
GNU General Public License v2.0
557 stars 107 forks source link

Added two additional compatible plugins to readme.txt #26

Closed herrvigg closed 6 years ago

herrvigg commented 6 years ago

Issue by mweimerskirch Friday Feb 20, 2015 at 21:36 GMT Originally opened as https://github.com/qTranslate-Team/qtranslate-x/pull/26

mweimerskirch included the following code: https://github.com/qTranslate-Team/qtranslate-x/pull/26/commits

herrvigg commented 6 years ago

Comment by johnclause Friday Feb 20, 2015 at 22:13 GMT

Thanks, Michel, all your PRs are really useful, I look through them in details shortly. One thing I spotted now, about "qtranslate-support-for-woocommerce". Last time I looked at it, it was not quite compatible with -X, nether were other available plugins for woocomerce integration. I had a client who needed it quickly and I ended up creating a new one specifically for -x, which will not work with other q* plugins. It is on GitHub https://github.com/qTranslate-Team/woocommerce-qtranslate-x only for now, but it was already approved on WP and I am waiting for the next release of Woocommerce before publishig it. Woocommerce kindly did a few changes in their code which I needed to implement -x's Language Buttons to work with some of woocommerce pages. The new integrating plugin also requires the latest -x from github https://github.com/qTranslate-Team/qtranslate-x to be complete. If you run woocommerce on your sites, it would be great if you try to test it all, could you?

herrvigg commented 6 years ago

Comment by mweimerskirch Friday Feb 20, 2015 at 23:12 GMT

I only learnt about qtranslate-X a few days ago, that's why my plugins weren't compatible before =) There might still be minor problems left, but we're using qtranslate-X at our company for new projects now, so I should be able to catch any issues in the next days. I also had a quick look at your WooCommerce plugin. I don't have the time to go through it in detail right now, but I noticed that it covers more filters (which we apparently didn't need yet). I'll try to find some time to test yours and compare them to evaluate whether to stick with our plugin or switch to yours.

herrvigg commented 6 years ago

Comment by johnclause Friday Feb 20, 2015 at 23:25 GMT

Well, as far I learned in the past, you would need to do pretty big changes on your plugin, since a lot of its code is no longer needed for -x, while -x has a new way of integrating, which would not be compatible with older q*. You would simply ended up doing a split in your code to do -x version, vs other versions. I think that it would be easier now to continue making sure that the new plugin is up to 100%. I have no problem to add you as an author and to share the support with you. Would you try to test it, before going any further with it? BTW, I forgot to mention, that you would need the latest Woocommerce from github too: https://github.com/woothemes/woocommerce