search

qtumproject / cpp-eth-qtum

GNU General Public License v3.0
9 stars 48 forks source link

Remove a lot of unused code that made us rely on unneeded depedencies #15

Closed Earlz closed 7 years ago

Earlz commented 7 years ago

This includes removing

  1. JSON output from tracing (we don't use tracing at all) which caused us to need json_spirit
  2. Removed threading code from Log support (we only use it in a single threaded context, so this provides us nothing while making us rely on specific pthread versions)
  3. Remove platform specific trap assembly code that made debugging marginally easier but broke on ARM and ARM64
  4. Reworked weird sha3 header files to work without too much headache
  5. Remove code from Ethash that assumed we would always be wanting to setup an Ethereum miner
  6. Changed secp256k1_ecdh_raw -> secp256k1_ecdh, so that we can use the same libsecp256k1 as Bitcoin relies on, rather than needing to also use a specific older version that ETH uses that has this named with _raw