search

qtwebkit / qtwebkit

Code in this repository is obsolete. Use this fork: https://github.com/movableink/webkit
478 stars 132 forks source link

can't build qtwebkit-dev on ubuntu 18.04 with conan #907

Open xlazom00 opened 4 years ago

xlazom00 commented 4 years ago

This patch help me a little when I want to build qtwebkit with conan on ubuntu https://github.com/Memsource/qt5-patch-set/blob/new_qtwebkit/qtwebkit/0001-fix-string-replace-for-conan.patch https://github.com/Memsource/qt5-patch-set/blob/new_qtwebkit/qtwebkit/0001-remove-WEBKIT_SET_EXTRA_COMPILER_FLAGS.patch

this is also nice if you have qt without PDF support https://github.com/Memsource/qt5-patch-set/blob/new_qtwebkit/qtwebkit/0001-build-without-qt-pdf-support.patch

but I don't know how to handle missing WOFF2 so I disabled WOFF support

xlazom00 commented 4 years ago

For some reason I need to create directory in building directory mkdir -p "WebKitLegacy/DerivedSources"

Another problem is empty CMAKE_INSTALL_PREFIX and QT_INSTALL_PREFIX

annulen commented 4 years ago

Why are you building on Ubuntu with Conan? All dependencies can be installed from apt, including libwoff-dev required for WOFF2 support

xlazom00 commented 4 years ago

As I don't want to make dependency on specific version installed on OS. So if you can add WOFF connan package, it will be nice :)

annulen commented 4 years ago

I'm not interested in this, however you can make feature request at https://github.com/conan-io/wishlist or do it yourself. It's also possible to do on commercial terms.

annulen commented 4 years ago

pdf fix is merged as 0f412d2c7febbd65fc898a031a2ee99a3c88e007

annulen commented 4 years ago

Why do you need https://github.com/Memsource/qt5-patch-set/blob/new_qtwebkit/qtwebkit/0001-remove-WEBKIT_SET_EXTRA_COMPILER_FLAGS.patch? It's a definitely wrong change

xlazom00 commented 4 years ago

@annulen WEBKIT_SET_EXTRA_COMPILER_FLAGS don't exist in qtwebkit-dev

annulen commented 4 years ago

Oh, indeed! Thanks.

annulen commented 4 years ago

FWIW, Conan packages of woff2 and brotli are now available