search

quackduck / aces

Encode in a character set of your choice
MIT License
68 stars 3 forks source link

Crashes upon running encoding with a string with two of the same letter #2

Open AverseABFun opened 4 months ago

AverseABFun commented 4 months ago

image

image

xplshn commented 4 months ago

I have modified the code and added an error to notify the user that the charset contains a duplicated character, shall I make it be a warning instead? I will make a PR once you answer

AverseABFun commented 4 months ago

Wow thanks, I was thinking maybe either it automatically changing the string to not have duplicate characters, but a warning works

xplshn commented 4 months ago

The decoding part I haven't checked, truth is I am not very familiar with this project's code, so, I will now check if this same issue happens when decoding or not

xplshn commented 4 months ago

Well, I didn't break anything it seems

2024-05-02-233334_1112x274_scrot

AverseABFun commented 4 months ago

Looks good, thanks!

On Thu, May 2, 2024, 9:34 PM xplshn @.***> wrote:

Well, I didn't break anything it seems

2024-05-02-233334_1112x274_scrot.png (view on web) https://github.com/quackduck/aces/assets/114888778/e05f5c9c-8210-4701-adbf-42fc2740ed74

— Reply to this email directly, view it on GitHub https://github.com/quackduck/aces/issues/2#issuecomment-2092035774, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATOOUFTI3GLGGZBNPNJBZJ3ZALZUFAVCNFSM6AAAAABHEXBBCWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJSGAZTKNZXGQ . You are receiving this because you authored the thread.Message ID: @.***>