search

quadram-institute-bioscience / dadaist2

Dadaist2 🟨 Highway to R
https://quadram-institute-bioscience.github.io/dadaist2/
MIT License
13 stars 5 forks source link

Possible typo in docker and singularity scripts #12

Closed vmikk closed 3 years ago

vmikk commented 3 years ago

Hello! There are duplicated lines in Docker and Singularity scripts which fetch the UNITE database:

    ./dadaist2/bin/dadaist2-getdb -d "dada2-unite" -o /dadaist_databases/
    ./dadaist2/bin/dadaist2-getdb -d "dada2-unite" -o /dadaist_databases/

It doesn't harm because dadaist skips downloading if the database is found, but anyway the lines are redundant.

With kind regards, Vladimir

telatin commented 3 years ago

Thanks for providing a fixed file. A more robust installation method should be shipped in the next two months.

Best Andrea