Closed nilsreiter closed 5 years ago
Some options are available in multiple functions, we should unify their names and meanings:
frequencytable()
names=FALSE
dictionaryStatistics()
configuration()
useCharacterId=FALSE
figureStatistics()
names = FALSE
All will be removed, because we will rely on ids only, and replace the names before exporting/printing.
by=c("Act", "Scene")
segment=c("Drama","Act","Scene")
by=c("Drama","Act","Scene")
All functions should use segment.
segment
Some options are available in multiple functions, we should unify their names and meanings:
Name or id
frequencytable()
has the optionnames=FALSE
dictionaryStatistics()
has the optionnames=FALSE
configuration()
has the optionuseCharacterId=FALSE
figureStatistics()
:names = FALSE
Solution
All will be removed, because we will rely on ids only, and replace the names before exporting/printing.
Segment
configuration()
:by=c("Act", "Scene")
dictionaryStatistics()
:segment=c("Drama","Act","Scene")
frequencytable()
:by=c("Drama","Act","Scene")
figureStatistics()
:segment=c("Drama","Act","Scene")
Solution
All functions should use
segment
.