search

quadrama / DramaAnalysis

An R package for analysis of dramatic texts
GNU General Public License v3.0
15 stars 2 forks source link

New function `split()` #140

Closed nilsreiter closed 5 years ago

nilsreiter commented 5 years ago

This is the opposite function of combine(), and used to split up a single QDDrama object that contains more than one play into a list.

t-lini commented 5 years ago

I'm not sure if it's best to implement it as the split-S3-method for class QDDrama, since the documentation for base::split() would be misleading. Maybe it is better to have it as a unique function splitDramas()?

nilsreiter commented 5 years ago

Good question. I didn't know that there is a base::split() function.

nilsreiter commented 5 years ago

Btw: We can have documentation specific for split.QDDrama(), so this would't be a problem. My vote is for keeping it as a generic S3 method.