quadrama / DramaAnalysis

An R package for analysis of dramatic texts
GNU General Public License v3.0
15 stars 2 forks source link

test fails #148

Closed nilsreiter closed 5 years ago

nilsreiter commented 5 years ago
Build ID:   DramaAnalysis_3.0.0.tar.gz-bde0f00fd0e84b6e9edec72ec0dd86db
Platform:   Ubuntu Linux 16.04 LTS, R-release, GCC
Submitted:  32 minutes 30.7 seconds ago
Build time: 32 minutes 27.3 seconds

Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
  1. Failure: frequencytable(rksp.0) 
            has correct dimensions and produces correct output (@test-frequencytable.R#10) 
  2. Failure: frequencytable(rksp.0) 
            has correct dimensions and produces correct output (@test-frequencytable.R#11) 
  3. Failure: frequencytable(rksp.0, byCharacter=TRUE, segment='Act') 
            has correct dimensions and produces correct output (@test-frequencytable.R#22) 
  4. Failure: frequencytable(rksp.0, byCharacter=TRUE, segment='Act') 
            has correct dimensions and produces correct output (@test-frequencytable.R#23) 
  5. Failure: frequencytable(rksp.0, segment='Scene', normalize=TRUE) 
            has correct dimensions and produces correct output (@test-frequencytable.R#33) 
  6. Failure: frequencytable(rksp.0, byCharacter=TRUE, segment='Scene', sep=';') 
            has correct dimensions and produces correct output (@test-frequencytable.R#44) 

  Error: testthat unit tests failed
  Execution halted

Full log output: https://builder.r-hub.io/status/DramaAnalysis_3.0.0.tar.gz-bde0f00fd0e84b6e9edec72ec0dd86db

Can be tested with: devtools::check_rhub(platforms = "ubuntu-gcc-release")

nilsreiter commented 5 years ago

@TimStrohmayer Läuft bei Dir zufällig auch ubuntu? Kennst Du dieses Problem? Auf einem Debian-Rechner geht das gut.

nilsreiter commented 5 years ago

Fix in 64bd490, was related to the sort order. Setting the locale to C before testing solved the problem.