quadrama / DramaAnalysis

An R package for analysis of dramatic texts
GNU General Public License v3.0
15 stars 2 forks source link

characterNames does not work with mode = Passive in configuration #168

Open pagelj opened 2 years ago

pagelj commented 2 years ago

Example:

> d <- loadDrama("gdc:rjmw.0")
> configuration(d) %>% characterNames(d)

corpus  drama    character    1    2    3    4    5
1     gdc rjmw.0  Sir William  300    0  979    0  773
2     gdc rjmw.0     Waitwell  314    0 1435    0   72
3     gdc rjmw.0     Der Wirt  324    0    0    0    0
4     gdc rjmw.0    Mellefont 1971 1398  809 2089 1709
5     gdc rjmw.0       Norton  444    0    0  381  176
6     gdc rjmw.0        Betty  174    0  100   33  175
7     gdc rjmw.0         Sara 1436    0 2774 2348 2563
8     gdc rjmw.0      Marwood    0 3784  284 3148    0
9     gdc rjmw.0       Hannah    0  258    0    0    0
10    gdc rjmw.0 Der Bediente    0   44    0    0    0
12    gdc rjmw.0     Arabella    0  398    0    0    0

> configuration(d, mode = "Passive") %>% characterNames(d)

corpus  drama    character   1   2   3   4   5
1     gdc rjmw.0  sir_william  29   0  78   4  60
2     gdc rjmw.0     waitwell  20   0 101   0  21
3     gdc rjmw.0    mellefont 154 142  59 171 141
4     gdc rjmw.0         sara 127   3 197 190 177
5     gdc rjmw.0     der_wirt  20   0   0   0   1
6     gdc rjmw.0       norton  31   0   0  36  21
7     gdc rjmw.0      marwood   5 252  34 168  22
8     gdc rjmw.0        betty  11   0  10   6  36
9     gdc rjmw.0       hannah   0  28   0   0   0
10    gdc rjmw.0 der_bediente   0   4   0   0   0
11    gdc rjmw.0     arabella   0  28   0   1   2
pagelj commented 2 years ago

The issue is that the character column is not a factor when using mode = "Passive"

pagelj commented 2 years ago

https://github.com/quadrama/DramaAnalysis/pull/170