quadratic-funding / mpc-phase2-suite

The MPC suite of tools for conducting zkSNARK Phase 2 Trusted Setup ceremonies
MIT License
16 stars 6 forks source link

Polish a message when the user retries to contribute to a circuit to which they already contributed #324

Open baumstern opened 1 year ago

baumstern commented 1 year ago

Currently, CLI output is like following:

   ___ _                      ____         _ _ 
  / _ \ |__   __ _ ___  ___  |___ \    ___| (_)
 / /_)/ '_ \ / _` / __|/ _ \   __) |  / __| | |
/ ___/| | | | (_| \__ \  __/  / __/  | (__| | |
\/    |_| |_|\__,_|___/\___| |_____|  \___|_|_|

Greetings, @gurrpi 👋

⚠ The contribution process is based on a waiting queue mechanism (one contributor at a time) with an upper-bound time constraint per each contribution (does not restart if the process is halted for any reason).
ℹ Any contribution could take the bulk of your computational resources and memory based on the size of the circuit 🔥

✔ Select a ceremony › bla
⚠ You are not eligible to contribute to the ceremony right now
✖ You are not eligible to contribute to the ceremony

Congrats, you have already contributed to 1 out of 1 circuits 🎉
✔ Circuit 1

We wanna thank you for your participation in preserving the security for bla Trusted Setup ceremony 🙏

See you, @gurrpi 👋
✨  Done in 10.45s.
0xjei commented 1 year ago

Do you think that the message below is not enough?

Congrats, you have already contributed to 1 out of 1 circuits 🎉
✔ Circuit 1
baumstern commented 1 year ago

Do you think that the message below is not enough?

Congrats, you have already contributed to 1 out of 1 circuits 🎉
✔ Circuit 1

IMO, it is not necessary to print following message in that case. It's just unnecessarily misleading.

⚠ You are not eligible to contribute to the ceremony right now
✖ You are not eligible to contribute to the ceremony

Also It doesn't need to prompt users to choose a ceremony because it doesn't actually do anything, but it creates the hallucination that you can contribute to the ceremony.

In this case, I think it's better to first check if a ceremony exists that the user can contribute to, and then let them choose.

0xjei commented 1 year ago

Do you think that the message below is not enough?

Congrats, you have already contributed to 1 out of 1 circuits 🎉
✔ Circuit 1

You're missing the point that there could be more than one ceremony open for contributions at the same time.

IMO, it is not necessary to print following message in that case. It's just unnecessarily misleading.

⚠ You are not eligible to contribute to the ceremony right now
✖ You are not eligible to contribute to the ceremony

The message above it should no longer be shown after the latest updates!

Also It doesn't need to prompt users to choose a ceremony because it doesn't actually do anything, but it creates the hallucination that you can contribute to the ceremony.

In this case, I think it's better to first check if a ceremony exists that the user can contribute to, and then let them choose.

Agree, the only thing was that we are exploiting the contribute command to retrieve information about the participant's contribution to the ceremony. Surely, this part will be moved to another command later on!