search

quadratic-funding / mpc-phase2-suite

The MPC suite of tools for conducting zkSNARK Phase 2 Trusted Setup ceremonies
MIT License
16 stars 6 forks source link

Chore: update to Yarn V3 #355

Closed 0xjei closed 1 year ago

0xjei commented 1 year ago

This PR is going to remove lerna and leverage on yarn workspaces only for handling the monorepo.

Also, this is going to fix some missing packages or wrong imports that were present (and not highlighted) with latest version. This is mandatory for needed patch.

baumstern commented 1 year ago

LGTM

baumstern commented 1 year ago

I noticed that you used the merge method to update your branch. While this is a valid method, I would like to encourage you to use the rebase method instead. The rebase method will apply your changes on top of the latest changes in the base branch, which will make it easier for the reviewer to see the changes you made and will also make it easier to resolve any conflicts that may arise. Here is a link to a resource that explains the difference between the two methods: https://www.atlassian.com/git/tutorials/merging-vs-rebasing.