quadratic-funding / mpc-phase2-suite

The MPC suite of tools for conducting zkSNARK Phase 2 Trusted Setup ceremonies
MIT License
16 stars 6 forks source link

Fix: CI test script failing due to missing `kill` PID after Jest execution #366

Closed 0xjei closed 1 year ago

baumstern commented 1 year ago
Screenshot 2023-03-27 at 21 49 49

When does this failure happen? The recent CI history shows it has been passed until the latest run.

baumstern commented 1 year ago

https://github.com/facebook/jest/issues/9324#issuecomment-1249682315 might be useful info

0xjei commented 1 year ago
Screenshot 2023-03-27 at 21 49 49

When does this failure happen? The recent CI history shows it has been passed until the latest run.

Mostly happened after switching to yarn 3 which doesn't like the kill argument at the end of the npm script (changed with pkill but didn't work).

baumstern commented 1 year ago

Closing this since the problem that this PR trying to solve has been fixed by https://github.com/quadratic-funding/mpc-phase2-suite/pull/371