search

quadrismegistus / prosodic

Prosodic: a metrical-phonological parser, written in Python. For English and Finnish, with flexible language support.
http://quadrismegistus.github.io/prosodic/
GNU General Public License v3.0
277 stars 43 forks source link

Refactoring code for better performance and code quality #37

Closed maldil closed 2 years ago

maldil commented 2 years ago

Hi Thank you very much for your excellent work in quadrismegistus/prosodic.

I am a graduate student at the University of Colorado, studying the best practices of evolving data science codes. From our research, one of the most common evolution best practice is the migration of loop-based computations, since it improves performance and code quality. We made the following changes in quadrismegistus/prosodic, which remove the FOR loop and use join(). I carefully checked the modification to ensure that it does not break the code. I will gladly contribute. Please help me to merge this.

maldil commented 2 years ago

Superb and thanks.

maldil commented 2 years ago

@tomaarsen could you please help to merge this PR?

tomaarsen commented 2 years ago

@tomaarsen could you please help to merge this PR?

I planned to let @quadrismegistus handle the merging, but I probably should have mentioned that in my approval message. It's all set now!