search

quadstorejs / quadstore

A LevelDB-backed graph database for JS runtimes (Node.js, Deno, browsers, ...) supporting SPARQL queries and the RDF/JS interface.
https://github.com/quadstorejs/quadstore
MIT License
203 stars 14 forks source link

String literal data type is not compacted #118

Closed gsvarovsky closed 3 years ago

gsvarovsky commented 3 years ago

https://github.com/beautifulinteractions/node-quadstore/blob/faf3cd5f694b329d0d486f07bbdd4dd835de7030/lib/serialization/import.ts#L19

The xsd.string data type is not subjected to compaction when using prefixes.

If it were compacted, it would still be subject to expansion in the current export module: https://github.com/beautifulinteractions/node-quadstore/blob/faf3cd5f694b329d0d486f07bbdd4dd835de7030/lib/serialization/export.ts#L14

jacoscaz commented 3 years ago

Ah, good catch. Will fix soon!

jacoscaz commented 3 years ago

Fixed this in https://github.com/beautifulinteractions/node-quadstore/commit/1400bbe15bb88976d6a8cc262bb8f7503e9ed5d2, will release in either 7.1.0 or the next beta. Let me know if this is urgent for you and I'll release another beta right away.