search

quaertym / ember-cli-dependency-checker

Ember CLI addon for checking missing node and bower dependencies before running ember commands
MIT License
40 stars 38 forks source link

Fix detection of bower dependencies installed from http(s) #12

Closed dschmidt closed 9 years ago

dschmidt commented 9 years ago

this.lookupBowerPackageVersion(name) returns null if a dependency is installed from http(s) and so the version check fails.

quaertym commented 9 years ago

@dschmidt This is already implemented and tested. see https://github.com/quaertym/ember-cli-dependency-checker/blob/master/lib/git-repo.js#L4

dschmidt commented 9 years ago

Uh oh. ok. Has this been released? :)

quaertym commented 9 years ago

Yep, v0.0.6. Also test is here: https://github.com/quaertym/ember-cli-dependency-checker/blob/v0.0.6/tests/unit/dependency-checker-bower-test.js#L71-74

dschmidt commented 9 years ago

But it does not work for me. Having these "ember-validations": "http://builds.dockyard.com.s3.amazonaws.com/ember-validations/stable/ember-validations.js", "ember-easyForm": "http://builds.dockyard.com.s3.amazonaws.com/ember-easyForm/canary/ember-easyForm.js" in my bower.json I cant launch ember-cli if ember-cli-d-c is enabled.

dschmidt commented 9 years ago

Ah, that .tar.gz possibly contains the bower.json? Bower installs from plain .js files without bower.json just fine too.

rwjblue commented 9 years ago

@quaertym - This likely fixes https://github.com/stefanpenner/ember-cli/issues/2591, can you take a look again?

green-arrow commented 9 years ago

@quaertym Bump on this as I'd like an answer. Having the same issue trying to resolve an http package.

quaertym commented 9 years ago

@green-arrow I had assumed all bower packages include a version string however this seems not true for static assets that are downloaded over http. The quick solution is to remove ember-cli-dependency-checker from your ember-cli project. The real solution is to investigate how bower manages these files and implement a solution accordingly. A temporary solution is to just skip these. I will definitely work on this issue this week.

green-arrow commented 9 years ago

@quaertym That sounds great. I've removed that package and all is well. Looking forward to the fix, and thanks for your work!

quaertym commented 9 years ago

Fixed by 6ddb025839393a12590d58f48329096b0e33b1ed.

green-arrow commented 9 years ago

:thumbsup: Works perfectly. Thanks!