quaertym / ember-cli-dependency-checker

Ember CLI addon for checking missing node and bower dependencies before running ember commands
MIT License
40 stars 37 forks source link

Bower deprecations in ember-cli 4.3 #128

Closed Windvis closed 2 years ago

Windvis commented 2 years ago

ember-cli 4.3 will include deprecations for all bower related apis. It seems that this addon is making use of some of those API's and since it's part of the default blueprint, these deprecations will be triggered when people start updating to the 4.3.

The easiest solution would be to simply drop bower support here and release a major version. Apps that do want the version checking for bower dependencies can stay on the v3 release? Alternatively we can manually replace the APIs with custom node code, so bower is still supported but the deprecations won't get triggered. I'm not sure if it's worth the time investment since I doubt projects on modern Ember are still using bower.

quaertym commented 2 years ago

I believe best way forward is to drop bower support.

Windvis commented 2 years ago

I think the consensus in Discord was that we can't simply remove it here yet since it's still supported in ember-cli.

The idea was that we would add some bower detection code, and only then run the bower dependency checking code here. That way the deprecation messages from ember-cli won't be shown in apps that don't use bower.

Maybe it would be better to explicitly show a deprecation warning from this addon as well (if bower is detected), since otherwise it might not be clear that this addon is the cause for those other deprecation messages.

SergeAstapov commented 2 years ago

@quaertym do you think #129 follows the spirit of that discussion? cc @Windvis

Also, we can do a major version bump of this package with:

Windvis commented 2 years ago

@SergeAstapov I think #129 is exactly what we needed. Thanks!

quaertym commented 2 years ago

@SergeAstapov Thanks for tackling this.