search

quaertym / ember-cli-dependency-checker

Ember CLI addon for checking missing node and bower dependencies before running ember commands
MIT License
40 stars 37 forks source link

null version detected for bower dependencies #13

Closed amk221 closed 9 years ago

amk221 commented 9 years ago

When pulling a bower dependancy from a git url like: git://github.com/amk221/my-thing.git _#master the dependancy is determined to be 'not installed' (therefore builds fail). It works without the #tag_

stefanpenner commented 9 years ago

This also seems to be a problem if the destination repo has no bower.json file. Such as: https://github.com/furf/jquery-ui-touch-punch

I suspect if the folder exists, but no bower.json file exists we should likely just best-effort assume all is satisfied.

quaertym commented 9 years ago

I was not sure how to handle this. @stefanpenner I will try your suggestion.

stefanpenner commented 9 years ago

@quaertym Ya, I am not quite sure the best way either, maybe someone else has a better idea.

For reference my solution/workaround was to merely "vendor" this dependency and commit it to my project manually.

quaertym commented 9 years ago

@stefanpenner :+1: for vendor approach but I think many users are not aware of it. We should cover this use case anyway. There is also a problem with static files that bower manages see this pr https://github.com/quaertym/ember-cli-dependency-checker/pull/12.

mixonic commented 9 years ago

Yeah, this bit us as well today. Ugly and more than a bit perplexing.

soulcutter commented 9 years ago

I ran into this with an http dependency

    "sinon": "http://sinonjs.org/releases/sinon-1.12.1.js"

Not sure if it's relevant, but I did notice that bower_components/sinon does have a .bower.json file in there - is that artifact usable in lieu of a bower.json file?

shaunc commented 9 years ago

I ran into the same "sinon" issue ... and also now have a problem with antiscroll as installed by ember-cli-ember-table. Could someone explain the "vendor" workaround? I have got things working temporarily by simply deleting the reference in bower.json after I install, but this is obviously just a temporary patch for development.

rupurt commented 9 years ago

@amk221 @stefanpenner thanks for the suggestion. Is there any tooling support for vendoring a dependency or do I just need to put it in the my_ember_app/vendor directory manually?

I've got it working manually but it would be nice if there was a command I could run to update the package.