search

quaertym / ember-cli-dependency-checker

Ember CLI addon for checking missing node and bower dependencies before running ember commands
MIT License
40 stars 37 forks source link

Replace Travis with GitHub actions #130

Closed SergeAstapov closed 2 years ago

SergeAstapov commented 2 years ago

Wonder if maintainer is up to this change.

quaertym commented 2 years ago

+1 from me. Let's remove appveyor as well in favor of github actions.

SergeAstapov commented 2 years ago

+1 from me. Let's remove appveyor as well in favor of github actions.

@quaertym the second commit in this PR does it, see "Remove AppVeyor config"

quaertym commented 2 years ago

We can remove the appveyor badge from README and add windows to matrix as you said.

SergeAstapov commented 2 years ago

@quaertym done! tests results - https://github.com/SergeAstapov/ember-cli-dependency-checker/pull/2/checks

SergeAstapov commented 2 years ago

@quaertym PR was updated, do you mind to turn on/approve GitHub Actions run?

SergeAstapov commented 2 years ago

as a follow up I can try to add ember-try scenarios to test against issues like #133

quaertym commented 2 years ago

Thanks, I merged this.

I think we should follow ember-cli and use same node versions (12.x, 14.x, 16.x). Any blockers for this?

SergeAstapov commented 2 years ago

Sorry for delay - yes, we had to bump dependencies to be able to use newer Node versions, ad it was done in https://github.com/quaertym/ember-cli-dependency-checker/pull/135