quaertym / ember-cli-dependency-checker

Ember CLI addon for checking missing node and bower dependencies before running ember commands
MIT License
40 stars 37 forks source link

Resolve #132 #133

Closed NullVoxPopuli closed 2 years ago

NullVoxPopuli commented 2 years ago

https://github.com/quaertym/ember-cli-dependency-checker/issues/132 https://stackoverflow.com/questions/71811139/not-able-to-create-a-new-ember-app-could-not-resolve-dependency-error?noredirect=1#comment126901983_71811139

bertdeblock commented 2 years ago

@quaertym, mind having a look at this PR? The current peer dependency statement breaks the ember new flow for NPM users. Specifically, the ~3.2.0 part.

quaertym commented 2 years ago

Let's go with ^3.2.0 || ^4.0.0 as suggested above.

NullVoxPopuli commented 2 years ago

Is there a test somewhere to ensure this problem doesn't happen again?

quaertym commented 2 years ago

Not sure what's the best way to test this. But I think it is safe until ember-cli 5.x is released.

NullVoxPopuli commented 2 years ago

I think, this would be a sufficient test to add in your CI:

ember new my-app --skip-npm
cd my-app
# remove line with your dependency
sed  '/"ember-cli-dependency-checker"/d' ./package.json
npm install
npm add --save-dev ember-cli-dependency-checker@file:../foo/bar/wherever
npm install

as long as everything has exit status code 0, that should be sufficient.

quaertym commented 2 years ago

@rwjblue any input on how to test this?

quaertym commented 2 years ago

BTW, I released this as v3.3.1.

SergeAstapov commented 2 years ago

@quaertym I assume we can have ember-try scenarios with different versions of ember-cli, including latest/beta?

rwjblue commented 2 years ago

Ya, using either ember-try or something like scenario-tester seems like the easiest setup.