search

quaertym / ember-cli-dependency-checker

Ember CLI addon for checking missing node and bower dependencies before running ember commands
MIT License
40 stars 38 forks source link

does not properly detect resolutions #139

Open runspired opened 2 years ago

runspired commented 2 years ago

pnpm and yarn both allow "resolutions" or "overrides", a mechanism for forcing a specific dependency onto a specific version. This includes the ability to point to a fully different package if necessary.

Dependency Checker does not check for these resolutions, leading it to error when it should likely just warn.

For instance using pnpm override like so will fail:

{
    "pnpm": {
        "overrides": {
            "ember-auto-import": "@runspired-forks/ember-auto-import@2.4.3"
        }
    }
}

with an error like so:

Missing yarn packages: 
Package: ember-auto-import
  * Specified: ^2.4.2
  * Installed: (not installed)

Run `yarn` to install missing dependencies.

Stack Trace and Error Report: /var/folders/51/51f8s9mn649fd4qbcmc998_m0000gp/T/error.dump.c0095d2c4be470061dd809f60478b47b.log
An error occurred in the constructor for ember-cli-dependency-checker at /Users/cthoburn/github/auditboard/auditboard-frontend/node_modules/.pnpm/ember-cli-dependency-checker@3.3.1_ember-cli@4.7.0/node_modules/ember-cli-dependency-checker

 ELIFECYCLE  Command failed with exit code 1.