search

quaertym / ember-cli-dependency-checker

Ember CLI addon for checking missing node and bower dependencies before running ember commands
MIT License
40 stars 38 forks source link

Installed package is not recognized #17

Closed indirect closed 9 years ago

indirect commented 9 years ago

I just upgraded to Ember 1.10 beta by adding "ember": "~1.10.0" to bower.json. I ran bower install, and everything installed. But the dependency checker fails when I try to start ember-cli:

$ ember s
version: 0.1.4

Missing bower packages: 
Package: ember
  * Specified: ~1.10.0
  * Installed: 1.10.0-beta.3

Please recognize packages that are correctly installed and meet the requested dependencies.

(tested on ember-cli-dependency-checker version 0.0.6 and 0.0.7)

quaertym commented 9 years ago

Have you tried specifying it as 1.10.0-beta.3 in your bower file?

indirect commented 9 years ago

Why would that be required? Bower installed a version that meets my requirement, and now I'm being told "not really".

On Mon, Jan 5, 2015 at 4:57 PM, Emre Unal notifications@github.com wrote:

Have you tried specifying it as 1.10.0-beta.3 in your bower file?

Reply to this email directly or view it on GitHub: https://github.com/quaertym/ember-cli-dependency-checker/issues/17#issuecomment-68810224

quaertym commented 9 years ago

This line semver.satisfies('1.10.0-beta.3', '~1.10.0') returns false and I agree that beta version does not satisfy the stable 1.10.0 version. I guess bower tries to do best match. You can manifest this dependency as "ember": ">1.10.0-beta.1" or open an issue for bower or semver.

indirect commented 9 years ago

Then please change the message to stop saying "run bower install to install missing dependencies", because that is false.

On Tue, Jan 6, 2015 at 5:22 AM, Emre Unal notifications@github.com wrote:

This line semver.satisfies('1.10.0-beta.3', '~1.10.0') returns false and I agree that beta version does not satisfy the stable 1.10.0 version. I guess bower tries to do best match. You can manifest this dependency as "ember": ">1.10.0-beta.1" or open an issue for bower or semver.

Reply to this email directly or view it on GitHub: https://github.com/quaertym/ember-cli-dependency-checker/issues/17#issuecomment-68864116

quaertym commented 9 years ago

The current version assumes the manifest is correct.

indirect commented 9 years ago

That's not the point; the error message is misleading (and flat out wrong in this case). It's extremely user-hostile to throw an error that says "fix this error by running bower install" but running bower install doesn't fix the error. This is the kind of thing that makes people give up on using Ember at all.

quaertym commented 9 years ago

This is going to be handled by another feature. See https://github.com/quaertym/ember-cli-dependency-checker/issues/16.