quaertym / ember-cli-dependency-checker

Ember CLI addon for checking missing node and bower dependencies before running ember commands
MIT License
40 stars 37 forks source link

Check for missing package deps on `init`. #2

Closed rwjblue closed 9 years ago

rwjblue commented 9 years ago

included is only called when building.

Checking for package deps on addon init will ensure that for non build related commands you still get checking.

quaertym commented 9 years ago

At first I tried this, but app is not passed to init as parameter, right?

rwjblue commented 9 years ago

app is not, but the project is. That should be sufficient for testing package deps.

You will still need to check bower deps via included.

quaertym commented 9 years ago

@rwjblue Two notes about this:

function EmberCLIDependencyChecker(project) {
// ...
}
module.exports = EmberCLIDependencyChecker;

but it does not work if I write addon like this:

module.exports = {
  name: 'ember-cli-dependency-checker',
  init: function(project) {
  }
};

Can you explain why for both of this?